Thread: Dev Queestion

BTW I also noticed a bit of a bug, in your closeRenderer method on the UI form (which I would HIGHLY suggest renaming to something like 'MainForm' as there is also a plugin DLL called UI and that is a bit confusing)

The method initially was setup to check to see if we needed to do a control.invoke, and if so it called itself recursively using the invoke, which then would not need the invoke anymore and go down the other branch of the if tree. The only problem here is this is done inside of a for loop, meaning you sort of get some runaway recursion. Watch what happens in the debugger if you set some breakpoints, the function calls itself like 5-6 times even when only 2 forms are open (2 monitors on my system).

I suggest the function be changed so it looks like this:

Code:

        public static void closeRenderer()
        {
            for (int i = 0; i < Core.UICollection.Count; i++)
            {
                if (Core.UICollection[i].InvokeRequired)
                {
                    Core.UICollection[i].Invoke(new MethodInvoker(delegate() { Core.UICollection[i].tmrClosing.Enabled = true; }));
                }
                else
                {
                    Core.UICollection[i].tmrClosing.Enabled = true;
                }
            }
        }

Note how we are just directly firing the other thread forms' timer directly, instead of re-calling the method. In a quick and cursory examination it didn't look like it was necessary (for something else) to be doing a recursive method call like that.

BTW Keep up the good work, I really like the direction this app is going.

Justin you mentioned that you wanted me to start working on a plugin, what did you have in mind?

Got busier with the holidays faster then I expected sorry I didn't get back to you sooner.

ok: I keep the projects in separate folders and then move it to the svn directory for commit which having to test on linux has also brought me to the realization that it screws up the directory structure so i'll make sure to sort that out for the next commit. Will also see whats up with the manifest, and add it if its missing.

As far as the pfx file, you can ignore that for now its only required for releases. The framework is signed so that it can be natively generated and installed in the gac when the program is installed. This cuts down the memory footprint a lot and even helps with startup time but its certainly not necessary for testing.

I was pretty sure I had re-written the closeRenderer function to get rid of the invoke loop but looking at the code somehow those changes were lost. I'll make sure thats fixed up with the next commit. Theres also about half a dozen bugs picked up in the pre-release so it should be pretty solid.

About that plugin... Un4seen development (http://www.un4seen.com/bass.html) recently gave permission to use the bass library in the project so I was thinking that might be something you would want to tackle. Take a look at the Bass.Net library and see if you would be interested in doing a Bass based Media Player plugin. If not, i have quite a few other projects you might prefer so no worries.

SVN should be fixed now

Cool, I will check out the bass lib stuff. I have been away on holiday for the thanksgiving weekend but I am flying back home now so I should have some time to look into it in the next little bit here.