Release Lyric Tagger

Quote:

---

Originally Posted by deus ex machina

You'd have to using something stupid like an IE control get popups that way.

---

sure, but nobody released his superb solution before (or at least i couldnt find it), and that was from my point of view the easiest and fastest way...

Quote:

---

Originally Posted by deus ex machina

I wrote a class that downloads web pages (without actually rendering them in IE) using the Winsock API, if you want it.

---

- you dont have to use the ie control - just use your control and return the search result - you can do all that in the search module...
- if you want, i can also integrate your class, but i think all search modules must be changed then cause of the different interface.

Try this out. It will probably go a lot faster if you download the text of the page in VB and just use the scripts to parse it. Make sure you have a reference to MSWINSCK.OCX if you try to use these in your project.

Quote:

---

Originally Posted by ReflexNPG

@johnwpb:
no lyrics? if they are not on the site, what are you expecting? if they are and the program does not get them, maybe you've found a bug, so let me know, fix it yourself...or take option 4!

---

Dude, I was trying to be nice in my last post, and even thanked you for your work. Well... I guess you did not see it that way.

Maybe the rest of us are wrong to make suggestions, report bugs and the like.

A VERY good suggestions was a couple posts back, that if you are offering no support for this, and it is released "As Is" then you should have made that very clear at the beginning as a simple statement.

When something is released, it is typical in these forums for people to make requests, and offer suggestions to improve upon whatever the item is. I have released scripts and skins myself, and have only been able to improve on them from suggestions from others.

In my case, your "plugin" locks my computer tight (3.2 Ghz machine), where the window can not even be dragged, the log stops and stays on one song for an EXTENDED amount of time, and crashes quite frequently. After all that it gets only about 10% of the lyrics at most when it does finally finished with what it was doing.

Lyrics are not available? sorry, thats not it, after running your plugin on a test directory, I ran Zortam on the SAME test directory, and it gets at least 75% of the SAME songs that yours gets maybe 10% of. (with the binary characters /unicode and clutter mixed in unfortunately)

Quote:

---

brainstorming? most posters even dont know how it's working and start complaining.

---

My opinion, take the criticism from Liquid Smoke, myself and a few others and learn from it. We DO know computers, custom scripting and programming both inside and outside of RR.

Sure, when something is released, some people will blindly criticize the work that has went into something. But, if you decide to release something to the public, you better damn well be prepared for that and not attack people for their criticism or opinions!

Again, thank you for your work on this, and for sharing, next time, however, you should make it clear that you do not want criticism or suggestions on what you have done and then you will just have "Thank You" posts in your thread..

@deus ex machina:
thx, i will take a look at it

@JohnWPB:
please use zortam

nice attitude:rolleyes:

New search module - copy the code 2 the new file "00_lyricsplugin.vbs" into directory searchmodules.
(JohnWPB asked 4 it, but he didnt know what 2 do or he was 2 lazy to do it ...:))

Code:

---

' search lyrics
'by Reflex 2006.12.08
Dim sartist,soldartist,stitle,bFound,sresult,serror

'Set oWscript = WScript
'Set oIe = CreateObject("Internetexplorer.Application")
'sartist = "Prince"
'stitle = "Kiss"
'Call searchtest()

Function searchtest()
        Call search()
        MsgBox sresult
End Function

Function dosearch()
        serror = ""
        sresult = ""
        stitle = oSearch.stitle
        sartist = oSearch.sartist
        Call search()       
        osearch.sresult = sresult
        osearch.serror = serror
End Function

Function sleep(ms)
        owscript.sleep ms
End Function


Function search()

On Error Resume Next

sartist = LCase(sartist)
If InStr(stitle, "(") > 0 Then
    stitle = Left(stitle, InStr(stitle, "(") - 1)
End If
   
    oie.Navigate "http://www.lyricsplugin.com/plugin/?artist=" & Replace(sartist, " ", "%20") & "&title=" & Replace(stitle, " ", "%20")

iReset = 0
'While oIe.busy
Do While oie.ReadyState <> 4
    Sleep 100
    iReset = iReset + 1
    If iReset > 1000 Then
        Exit Do
    End If
Loop
Sleep 500

If Len(oie.Document.body.innertext) < 130 + Len(sartist) + Len(stitle) Then
    serror = "Song not found"
Else
        sresult = LCase(oie.Document.body.innertext)
        For i = 1 To 2
          sresult = Right(sresult, Len(sresult) - InStr(sresult, Chr(10)))
          sresult = Left(sresult, InStrRev(sresult, Chr(10)) - 2)
        Next
End If

End Function

---

Quote:

---

(JohnWPB asked 4 it, but he didnt know what 2 do or he was 2 lazy to do it ...)

---

That's a funny one. Apparently you haven't been following JohnWPB's work on this forum. We all appreciate your work and willingness to share, but in one short thread you have managed to insult two of the biggest contributors to the forum - Liquid Smoke and JohnWPB.

eh, i could care less. I just asked a simple question about how it works. For some reason some people always think they are being attacked or criticized when they aren't. Im sure JohnWPB could easily just say the app was crap and that would be enough for a lot of people to just avoid it. Suggestions are made to largely help you or your efforts become better, they shouldn't be taken as insults or trashing your thread. But i do see you have a new search module now :rolleyes: