Custom Indicator Bug

JohnWPB · 03-27-2008, 03:31 AM

When an indicator is turned on, and then off, you can not turn it back on again. If you reload the skin, it will show up as being on again.

I have confirmed this here with the following lines in my exectbl.ini :

"CD1On","setind;CUSTOMLoadedCD1;On"
"CD1Off"," setind;CUSTOMLoadedCD1;Off"

(I also tried the original ! to define the custom indicator, just for testing with the same results)

I execute CD1On the indicator turns on
I execute CD1Off, it goes off
executing CD1On again, the indicator fails to light, no matter how many times you cycle it on or off. The only way to get it to appear, is to turn it on, and then do a skin reload.

I have tested this here extensively with multiple indicators. I also had BlueZX3 test this and he had the same results I am describing.

This only seems to effect custom indicators, as the shuffle, repeat, mute and such work correctly cycling on,off,on,off ect.

Sonicxtacy02 · 03-27-2008, 08:12 AM

Quote: Originally Posted by JohnWPB

When an indicator is turned on, and then off, you can not turn it back on again. If you reload the skin, it will show up as being on again.

I have confirmed this here with the following lines:
setind;CUSTOMLoadedCD1;On
setind;CUSTOMLoadedCD1;Off

(I also tried the original ! to define the custom indicator, just for testing with the same results)

I execute the first line the indicator turns on
I execute the 2nd line, it goes off
executing the first line again, the indicator fails to light, no matter how many times you cycle it on or off. The only way to get it to appear, is to turn it on, and then do a skin reload.

I have tested this here extensively with multiple indicators. I also had BlueZX3 test this and he had the same results I am describing.

This only seems to effect custom indicators, as the shuffle, repeat, mute and such work correctly cycling on,off,on,off ect.

i told guino about this a few weeks ago via pm and i dont think i was clear enough in explaining what was goin on. It has something to do with the extension plugin interface. Notate all your extension plugins and the problem will go away. It may be movietimes thats causing the issue but i havent personally had the problem with movietimes... i'm having it with my traffic plugin thats not out yet. I have NO idea how to fix it because my traffic plugin doesnt even HAVE indicators in it. Its definitely something that need be fixed though because my ratings plugin doesnt work when i'm testing the traffic plugin.

Sonicxtacy02 · 03-27-2008, 08:14 AM

here's my convo with guino regarding it. I never really got an answer.(read from the bottom up)

Quote: Originally Posted by guino
You need to send out commands to return = "False" whenever the indicator goes off -- this will also provide so that you won't be "resetting" values when they're already off.

Quote: Originally Posted by Sonicxtacy02
I guess i didnt explain things clearly. I'm doing the indicators in my extension plugin the same way the example does them. And like you suggested i removed the default "false" statement. Doing this makes any custom indicators defined in the skin NOT turn off once they've been turned on. My ratings plugin is NOT an extension plugin, all it does is send SETIND;CUSTOMINDICATOR;ON/OFF depending on if the current song is found in a playlist file. The custom indicators its switching (which have nothing to do with the extension plugin) do not turn off once they've been turned on.

Quote: Originally Posted by guino
SETIND should not be used with codes defined in extension plugins -- it is only meant for CUSTOM indicators (they should start with ! or the word CUSTOM). Your extension plugin should not affect custom indicators either (unless you explicitly tell it to), so the two thinks should be working completely separately and independently. Still, I'm pretty sure that the base code for extension plugins defines "myindicator" as a test indicator code, and if you're using that code for testing with setind, chances are SOME plugin (maybe not yours) is overriding it.

Quote: Originally Posted by Sonicxtacy02
Something i've noticed while fixing my extension plugin... this is tested in both the 12-13 version and the latest beta. If i remove ReturnIndicator = "False" from the indicator function it creates a bug with SETIND. SETIND;MYIndicator;ON works but SETIND;MyIndciator;OFF does not turn the indicator off. No errors are shown in the debug.txt and rr goes on as normal. I tried this with my ratings plugin and just using exec.exe to change a custom indicator and both methods showed the same results. If i add ReturnIndicator = "False" back to the extension plugin the SETIND bug fixes itself. Any feedback about this?

Quote: Originally Posted by guino
Yes, there was a design issue with the indicators returned from extension plugins.

This has been corrected on the latest RR version, there's a BETA 12-13 that should have it fixed, then it is important that the plugin itself doesn't return a value or returns "" (Empty) and not "true"/"false", that is, when the indicator code is not a code from your plugin. That should allow other plugins to process codes afterwards. The example plugin has it returning "false" by default -- that is not the correct procedure -- it should only set returnindicator= >IF AND ONLY IF< it is an indicator code processed in your plugin.

The Beta is here:
http://guino.home.insightbb.com/RoadRunnerBeta.zip

Quote: Originally Posted by Sonicxtacy02
Gotta quick ? about a problem i'm having with indicators in my extension plugin. The movietimes plugin is the one i'm talking about. The indicators created by my plugin conflict with other indicators from other extension plugins. What could cause this. I know there are no variables named the same or anything like that, and most plugins seem to work with my plugin just fine. One plugin that i know has given people problems is the MP3ART plugin. It seems that making my plugin load first cures the indicator issues from my plugin but mp3arts plugins may be affected. Any idea on some causes for this.

JohnWPB · 03-27-2008, 04:03 PM

I edited my first post to indicate that all of the code for the indicators is in my exectbl.ini. I am not using any type of extension plugin at all. Just simple commands in the exectbl.

Sonicxtacy02 · 03-27-2008, 05:10 PM

then maybe its not directly related to the extension plugin interface at all.. that would certainly give me relief! Might mean i can release the traffic beta tomorrow! lol